Skip to content

[stable9.1] Create new birthday calendar without VTODO and give order 100 #28550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Oct 16, 2017
Merged

[stable9.1] Create new birthday calendar without VTODO and give order 100 #28550

PVince81 merged 1 commit into from
Oct 16, 2017

Conversation

@tomneedham
Copy link
Contributor

@tomneedham tomneedham commented Aug 1, 2017 •
edited
Loading

Backport of #28011 to stable9.1.

Tested in UI, installing owncloud + calendar, checking created system calendar

@tomneedham tomneedham added this to the development milestone Aug 1, 2017
@tomneedham tomneedham self-assigned this Aug 1, 2017
@tomneedham
Copy link
Contributor Author

tomneedham commented Aug 1, 2017

Since we don't have migrations in <OC10, this doesn't fix previous created calendars. Repair step @DeepDiver1975 ?

@DeepDiver1975 DeepDiver1975 changed the title Create new birthday calendar without VTODO and give order 100 [stable9.1] Create new birthday calendar without VTODO and give order 100 Aug 1, 2017
@DeepDiver1975
Copy link
Member

DeepDiver1975 commented Aug 1, 2017

Since we don't have migrations in <OC10, this doesn't fix previous created calendars. Repair step

hmmmm .... if necessary yes .... but we want people to move to oc10 .... ;-)

@PVince81
Copy link
Contributor

PVince81 commented Aug 3, 2017

Can we merge this ? If a repair step is needed then separately...

@tomneedham
Copy link
Contributor Author

tomneedham commented Aug 3, 2017

Can we merge this ? If a repair step is needed then separately...

this fixes the problem for new installs, doesn't fix old installs where this is already broken => we should probably add the repair step -> separately is fine

@PVince81
Copy link
Contributor

PVince81 commented Aug 10, 2017

still no review and still "2 - Developing". Moving to "planned" for the next release

@PVince81 PVince81 modified the milestones: planned, development Aug 10, 2017
@tomneedham tomneedham force-pushed the stable9.1-birthday-fix branch from 71167b4 to aaaee07 Compare October 10, 2017 12:34
@tomneedham
Copy link
Contributor Author

tomneedham commented Oct 10, 2017

Rebased to kick jenkins timeout

PVince81
PVince81 approved these changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit f9340ae into stable9.1 Oct 16, 2017
@PVince81 PVince81 deleted the stable9.1-birthday-fix branch October 16, 2017 10:00
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@felixboehm felixboehm Awaiting requested review from felixboehm

1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tomneedham tomneedham

Labels

3 - To Review status/STALE

Projects

None yet

Milestone

10.0.5

Development

Successfully merging this pull request may close these issues.

5 participants

@tomneedham @DeepDiver1975 @PVince81 @ownclouders